Skip to content

Use TypeScript for Charts components #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greenbonebot merged 15 commits into from
Jan 8, 2026
Merged

Use TypeScript for Charts components #5051

greenbonebot merged 15 commits into from
Jan 8, 2026
+1,031 −826

Conversation

@bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Jan 6, 2026

What

Use TypeScript for Charts components

Why

Convert all chart components to TypeScript for better code quality and early type checks.

References

https://jira.greenbone.net/browse/GEA-1496

@bjoernricks bjoernricks requested a review from a team as a code owner January 6, 2026 14:28
@greenbonebot greenbonebot enabled auto-merge (rebase) January 6, 2026 14:28
@github-actions
Copy link

github-actions bot commented Jan 6, 2026 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 62fd26b.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/@types/d3 3.5.53 🟢 7
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 9Found 29/30 approved changesets -- score normalized to 9
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
License🟢 9license file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Fuzzing⚠️ 0project is not fuzzed
npm/@types/d3-cloud 1.2.9 🟢 7
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 9Found 29/30 approved changesets -- score normalized to 9
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
License🟢 9license file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Fuzzing⚠️ 0project is not fuzzed
npm/@types/d3-hierarchy 3.1.7 🟢 7
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 9Found 29/30 approved changesets -- score normalized to 9
Maintained🟢 1030 commit(s) and 1 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
License🟢 9license file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies🟢 8dependency not pinned by hash detected -- score normalized to 8
Fuzzing⚠️ 0project is not fuzzed

Scanned Files

  • package-lock.json

daniele-mng
daniele-mng reviewed Jan 6, 2026
View reviewed changes
daniele-mng
daniele-mng reviewed Jan 6, 2026
View reviewed changes
@codecov
Copy link

codecov bot commented Jan 7, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 30.95238% with 116 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.59%. Comparing base (62e821b) to head (62fd26b).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/web/components/chart/base/Line.tsx 23.72% 38 Missing and 7 partials ⚠️
src/web/components/chart/Donut.tsx 7.69% 10 Missing and 2 partials ⚠️
src/web/components/chart/Schedule.tsx 26.66% 11 Missing ⚠️
src/web/components/chart/base/Legend.tsx 28.57% 8 Missing and 2 partials ⚠️
src/web/components/chart/Bar.tsx 12.50% 6 Missing and 1 partial ⚠️
src/web/components/chart/base/LegendLine.tsx 30.00% 7 Missing ⚠️
src/web/components/chart/Bubble.tsx 16.66% 5 Missing ⚠️
src/web/components/chart/donut/Arc3d.tsx 16.66% 4 Missing and 1 partial ⚠️
src/web/components/chart/donut/Paths.tsx 44.44% 5 Missing ⚠️
src/web/components/chart/WordCloud.tsx 0.00% 4 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5051      +/-   ##
==========================================
- Coverage   75.68%   75.59%   -0.10%     
==========================================
  Files        1131     1132       +1     
  Lines       29643    29647       +4     
  Branches     8830     8846      +16     
==========================================
- Hits        22436    22411      -25     
- Misses       6447     6471      +24     
- Partials      760      765       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjoernricks
Add a type for the translation function to gmp/locale
ba8e764
@bjoernricks
Add: Introduce a generic module for reusable types in gmp
a3dfcf0 
Add a ToString type which is used at several places already.
@bjoernricks
Allow for undefined and null in setRef
38303d2 
The function can handle both already.
@bjoernricks
Require packages for types of d3-cloud and d3-hierarchy
976c198 
Both packages are used for the charts.
@bjoernricks
Change: Use TypeScript for Chart base components
c6cdfc1
@bjoernricks
Move base chart components into a base sub directory
d788a6c
@bjoernricks
Change: Use TypeScript for Donut chart and its components
789f8a1
@bjoernricks
Change: Use TypeScript for chart components
24ec878
@bjoernricks
Derive SeverityClassData from LegendData
8ea03e0
@bjoernricks
Adapt imports to new chart module layout
e0f8319
@bjoernricks
Extract some LegendLine and LegendLabel components from Legend
ba678fc 
These two components are used outside of the Legend component and
therefore should be in their own module.
@bjoernricks
Update formatting to keep eslint happy
84aec1d
@bjoernricks
Update translation for placeholder variable renaming to camelCase
38cfecc
@bjoernricks
Update types for line chart axis labels
dcce6bc 
VxAxis allows for string only. We need to allow ToString for
LazyTranslation too.
@bjoernricks
Change: Try to avoid using index as key for chart tooltips
62fd26b 
Using an index as key is not a good solution because the index might
belong to a different data element in the next render.
@greenbonebot greenbonebot merged commit c68a038 into main Jan 8, 2026
22 checks passed
@greenbonebot greenbonebot deleted the typescript-charts branch January 8, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-mng daniele-mng daniele-mng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bjoernricks @daniele-mng @greenbonebot